rune/oai-swift
1
0
Fork 0
Code Issues Pull Requests Releases 12 Activity

Remove now-dead isContactsHiddenPendingAppleFix kill switch

Browse Source 
Contacts was never actually broken by an Apple/OS bug -- it was a
wrong entitlement key in oAI.entitlements, now fixed (abf25bd). No
functional change here: the flag was already false in both places
this session, so behavior is identical; this just removes the
now-pointless beta-badge/conditional-row scaffolding built around it.
This commit is contained in:
rune
2026-07-21 15:01:19 +02:00
parent abf25bd897
commit e9aceca4e7
2 changed files with 12 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
oAI/Services/SettingsService.swift
+4 -10
View File
@@ -25,17 +25,11 @@ import Foundation
import os
import Security
/// Kill switch for the Personal Data tools (Calendar/Reminders/Contacts/Location & Maps).
/// Flip `isHiddenPendingAppleFix` back to `false` once Apple fixes the macOS 27 beta TCC bug
/// (filed with Apple). Each flag hides the relevant UI and forces the `*Enabled` getter to
/// return `false` regardless of the persisted DB value — no code deleted, just inert.
/// Kill switch for the entire Personal Data tools section (Calendar/Reminders/Contacts/
/// Location & Maps). Hides the UI and forces every `*Enabled` getter to return `false`
/// regardless of the persisted DB value — no code deleted, just inert.
enum PersonalDataTools {
/// Hides the entire Personal Data section. Flip to `false` once all four services work.
static let isHiddenPendingAppleFix = false
/// Hides only the Contacts row. Was broken under hardened runtime on macOS 27 beta 2
/// (Calendar/Reminders/Location were fine). Re-enabled 2026-07-21 to retest on beta 4 —
/// flip back to `true` if `CNContactStore.requestAccess` still fails under signed builds.
static let isContactsHiddenPendingAppleFix = false
}
@Observable
@@ -719,7 +713,7 @@ class SettingsService {
}
var contactsEnabled: Bool {
get { !PersonalDataTools.isHiddenPendingAppleFix && !PersonalDataTools.isContactsHiddenPendingAppleFix && cache["contactsEnabled"] == "true" }
get { !PersonalDataTools.isHiddenPendingAppleFix && cache["contactsEnabled"] == "true" }
set {
cache["contactsEnabled"] = String(newValue)
DatabaseService.shared.setSetting(key: "contactsEnabled", value: String(newValue))