Actually commit the oAITests target wiring in project.pbxproj

The oAITests PBXNativeTarget (PBXContainerItemProxy, PBXTargetDependency, XCBuildConfiguration with TEST_HOST/BUNDLE_LOADER, the "recommended settings" changes accepted when the target was created -- DEAD_CODE_STRIPPING, CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, STRING_CATALOG_GENERATE_SYMBOLS, DEVELOPMENT_TEAM moved to project-level inheritance) was somehow never actually staged in the very first "Add real oAITests target" commit (8c7fb59) despite every xcodebuild test run since then depending on it being present on disk. Every subsequent commit this session only staged specific file paths (never oAI.xcodeproj again), so the gap went unnoticed until a full `git status` review here. Without this, anyone else pulling the branch (or a truly clean checkout on this machine) would have all the .swift test files but no target to compile them into -- xcodebuild test would fail to find oAITests at all. Confirmed the diff is exactly the expected target-wiring content, nothing unrelated or corrupted, before committing.
2026-07-23 14:19:53 +02:00
parent a053d4a983
commit 02bf73fec6
9 changed files with 464 additions and 72 deletions
@@ -103,4 +103,60 @@ struct ChatViewModelPureLogicTests {
        let pricing = ModelInfo.Pricing(prompt: 3.0, completion: 15.0)
        #expect(ChatViewModel.calculateCost(usage: usage, pricing: pricing) == 0.0)
    }
+
+    // MARK: - shouldAutoSave
+
+    private func autoSaveEligible(
+        syncEnabled: Bool = true,
+        syncAutoSave: Bool = true,
+        syncConfigured: Bool = true,
+        isCloned: Bool = true,
+        chatMessageCount: Int = 10,
+        minMessages: Int = 4,
+        lastSavedConversationId: String? = nil,
+        currentConversationHash: String = "hash-a"
+    ) -> Bool {
+        ChatViewModel.shouldAutoSave(
+            syncEnabled: syncEnabled,
+            syncAutoSave: syncAutoSave,
+            syncConfigured: syncConfigured,
+            isCloned: isCloned,
+            chatMessageCount: chatMessageCount,
+            minMessages: minMessages,
+            lastSavedConversationId: lastSavedConversationId,
+            currentConversationHash: currentConversationHash
+        )
+    }
+
+    @Test("Eligible when every criterion is satisfied")
+    func autoSaveEligibleWhenAllCriteriaMet() {
+        #expect(autoSaveEligible())
+    }
+
+    @Test("Not eligible when sync or auto-save is disabled")
+    func autoSaveIneligibleWhenDisabled() {
+        #expect(!autoSaveEligible(syncEnabled: false))
+        #expect(!autoSaveEligible(syncAutoSave: false))
+    }
+
+    @Test("Not eligible when sync isn't configured or the repo isn't cloned")
+    func autoSaveIneligibleWhenNotConfiguredOrCloned() {
+        #expect(!autoSaveEligible(syncConfigured: false))
+        #expect(!autoSaveEligible(isCloned: false))
+    }
+
+    @Test("Not eligible below the minimum message count")
+    func autoSaveIneligibleBelowMinimumMessages() {
+        #expect(!autoSaveEligible(chatMessageCount: 2, minMessages: 4))
+    }
+
+    @Test("Not eligible if this exact conversation was already auto-saved")
+    func autoSaveIneligibleWhenAlreadySaved() {
+        #expect(!autoSaveEligible(lastSavedConversationId: "hash-a", currentConversationHash: "hash-a"))
+    }
+
+    @Test("Eligible when the last saved hash differs from the current conversation")
+    func autoSaveEligibleWhenConversationChanged() {
+        #expect(autoSaveEligible(lastSavedConversationId: "hash-a", currentConversationHash: "hash-b"))
+    }
 }